call gtk_notebook_detach_tab only if the tab is detached
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1398234
parent
35583b2b68
commit
2c530ab0d3
|
@ -44,6 +44,8 @@
|
||||||
#include "skey-popup.h"
|
#include "skey-popup.h"
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
static gboolean detach_tab = FALSE;
|
||||||
|
|
||||||
struct _TerminalWindowPrivate
|
struct _TerminalWindowPrivate
|
||||||
{
|
{
|
||||||
GtkActionGroup *action_group;
|
GtkActionGroup *action_group;
|
||||||
|
@ -2637,8 +2639,15 @@ terminal_window_remove_screen (TerminalWindow *window,
|
||||||
|
|
||||||
screen_container = terminal_screen_container_get_from_screen (screen);
|
screen_container = terminal_screen_container_get_from_screen (screen);
|
||||||
#if GTK_CHECK_VERSION(3, 16, 0)
|
#if GTK_CHECK_VERSION(3, 16, 0)
|
||||||
|
if (detach_tab)
|
||||||
|
{
|
||||||
gtk_notebook_detach_tab (GTK_NOTEBOOK (priv->notebook),
|
gtk_notebook_detach_tab (GTK_NOTEBOOK (priv->notebook),
|
||||||
GTK_WIDGET (screen_container));
|
GTK_WIDGET (screen_container));
|
||||||
|
detach_tab = FALSE;
|
||||||
|
}
|
||||||
|
else
|
||||||
|
gtk_container_remove (GTK_CONTAINER (priv->notebook),
|
||||||
|
GTK_WIDGET (screen_container));
|
||||||
#else
|
#else
|
||||||
gtk_container_remove (GTK_CONTAINER (priv->notebook),
|
gtk_container_remove (GTK_CONTAINER (priv->notebook),
|
||||||
GTK_WIDGET (screen_container));
|
GTK_WIDGET (screen_container));
|
||||||
|
@ -2669,6 +2678,9 @@ terminal_window_move_screen (TerminalWindow *source_window,
|
||||||
*/
|
*/
|
||||||
g_object_ref_sink (screen_container);
|
g_object_ref_sink (screen_container);
|
||||||
g_object_ref_sink (screen);
|
g_object_ref_sink (screen);
|
||||||
|
|
||||||
|
detach_tab = TRUE;
|
||||||
|
|
||||||
terminal_window_remove_screen (source_window, screen);
|
terminal_window_remove_screen (source_window, screen);
|
||||||
|
|
||||||
/* Now we can safely remove the screen from the container and let the container die */
|
/* Now we can safely remove the screen from the container and let the container die */
|
||||||
|
|
Loading…
Reference in New Issue