gatuno
/
gatuno-terminal
1
0
Fork 0
Code Issues Pull Requests Releases 1 Wiki Activity

Properly check gdk_property_get result 

Check return value of gdk_property_get in get_initial_workspace before using its result

Current implementation segfaults from to time if terminal is started at X session startup

Looks like #769947 bug in Debian describes same issue
master-1.22
Nikolay Martynov 2014-11-24 22:46:51 -05:00
parent 1c238948e9
commit bb659a752e
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/terminal.c
View File

@ -532,10 +532,10 @@ get_initial_workspace (void)
atom = gdk_atom_intern_static_string ("_NET_CURRENT_DESKTOP");
cardinal_atom = gdk_atom_intern_static_string ("CARDINAL");
gdk_property_get (window, atom, cardinal_atom, 0, 8, FALSE, NULL, NULL, NULL, &data);
ret = *(int *)data;
g_free (data);
if (gdk_property_get (window, atom, cardinal_atom, 0, 8, FALSE, NULL, NULL, NULL, &data)) {
ret = *(int *)data;
g_free (data);
}
return ret;
}